Return promises inside Promise.all map #1787
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this code doesn't return anything inside the
map()
callback, resulting in an array with undefined elements, andPromise.all()
immediately returning.matrix-appservice-irc/src/bridge/MatrixHandler.ts
Lines 766 to 768 in b0fb738
Fixed it by adding a
return
but could also be styled asCaught this when I added my standard eslint config to my fork, might be useful to include the
array-callback-return
rule here too.