Node18 updates and Timer -> Timeout change #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
variable typing is off with what clearTimeout() is expecting so adjusting to match what (clear|set)Timeout() are expecting Signed-off-by: John 'Warthog9' Hawley <[email protected]>
…e correctly Signed-off-by: John 'Warthog9' Hawley <[email protected]>
Half-Shot
approved these changes
Jan 25, 2024
|
Signoff is in the commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes really but this is what got the bridge running for me on Node18 on Debian bookworm. Mostly a minor update to the package resolution so it all matches, as well as changing the Timer to Timeout, which is what (clear|set)Timeout is using now seemingly. Confirmed it's up and running and not seemingly doing anything amiss so submitting this upstream.