send history in MUCs #227
Open
send history in MUCs #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaller94
reviewed
Jan 26, 2021
uhoreg
commented
Jan 29, 2021
|
We should only send room history when the room's history visibility settings allow users to see history. What is the best way to get the room's history settings? |
jaller94
reviewed
Feb 4, 2021
| */ | ||
| interface IHistoryStorage { | ||
| // add a message to the history of a given room | ||
| addMessage: (chatName: string, message: Element, jid: JID) => unknown; |
There was a problem hiding this comment.
Why allow unknown to be returned and not just void?
There was a problem hiding this comment.
Because it could be async and return Promise<void>
Comment on lines
+61
to
+62
| // TODO: make a class that stores in PostgreSQL so that we don't lose history | ||
| // when we restart |
There was a problem hiding this comment.
Do you want to file that as an issue or address this before merging this PR?
There was a problem hiding this comment.
Probably just file as an issue.
Co-authored-by: Christian Paul <[email protected]>
Half-Shot
approved these changes
Feb 5, 2021
Half-Shot
requested changes
Feb 5, 2021
|
hi, can this be merged now? it seems the requested changes have been resolved and the reviewer removed themselves. This would mitigate the downsides of missing #64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.