Fix rendering of comments of GitLab merge requests (#937)

* Fix rendering of comments of GitLab merge requests Signed-off-by: Kévin Commaille <[email protected]> * Add changelog Signed-off-by: Kévin Commaille <[email protected]> * Change variable name to appease linter Signed-off-by: Kévin Commaille <[email protected]> --------- Signed-off-by: Kévin Commaille <[email protected]>
matrix-org · Jun 19, 2024 · 8630657 · 8630657
1 parent 7573d37
commit 8630657
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/changelog.d/937.bugfix b/changelog.d/937.bugfix
@@ -0,0 +1 @@
+Fix rendering of comments of GitLab merge requests.
diff --git a/src/Connections/GitlabRepo.ts b/src/Connections/GitlabRepo.ts
@@ -785,14 +785,18 @@ ${data.description}`;
         const target = relation ? '' : ` MR [${orgRepoName}!${mergeRequest.iid}](${mergeRequest.url}): "${mergeRequest.title}"`;
         let content = `**${result.author}** ${action}${target} ${comments}`;
 
+        let formatted = '';
         if (result.commentNotes) {
             content += "\n\n> " + result.commentNotes.join("\n\n> ");
+            formatted = md.render(content);
+        } else {
+            formatted = md.renderInline(content);
         }
 
         const eventPromise = this.intent.sendEvent(this.roomId, {
             msgtype: "m.notice",
             body: content,
-            formatted_body: md.renderInline(content),
+            formatted_body: formatted,
             format: "org.matrix.custom.html",
             ...relation,
         }).catch(ex  => {