Add support for crypto store PVC to helm chart #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PseudoResonance <[email protected]>
Half-Shot
requested changes
Apr 8, 2024
| @@ -92,6 +92,15 @@ resources: {} | |||
| # cpu: 100m | |||
| # memory: 128Mi | |||
|
|
|||
| # Persistent volume for encryption store, mounted in the pod as /persistent. | |||
There was a problem hiding this comment.
Do we need to configure hookshot to use this?
|
Yes, the following needs to be added to the Helm values under experimentalEncryption:
storagePath: /persistent |
|
Can this please be merged? We need this feature very urgently, as there are currently only functioning webhooks with hookshot. And it is important that these are encrypted. Thank you in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a persistence section to the Helm chart so that the encryption crypto store can persist through restarts/updates.