Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin the Node minor version for Docker builds #949

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Pin the Node minor version for Docker builds #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dc0fa0
Pin the Node minor version for Docker builds
AndrewFerr Jun 21, 2024
c5261a9
Add changelog
AndrewFerr Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Stage 0: Build the thing
# Need debian based image to build the native rust module
# as musl doesn't support cdylib
FROM node:20-slim AS builder
FROM node:20.12-slim AS builder

# Needed in order to build rust FFI bindings.
RUN apt-get update && apt-get install -y build-essential cmake curl pkg-config pkg-config libssl-dev
Expand Down Expand Up @@ -29,7 +29,7 @@ RUN yarn build


# Stage 1: The actual container
FROM node:20-slim
FROM node:20.12-slim

WORKDIR /bin/matrix-hookshot

Expand Down
1 change: 1 addition & 0 deletions changelog.d/949.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Pin the minor version of Node for Docker builds to avoid a startup crash on arm64.
Loading