Fix unhandled callback when the session is nil. (#1833)

matrix-org · Nov 23, 2023 · f72d833 · f72d833
1 parent c91b556
commit f72d833
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 15 deletions.
diff --git a/MatrixSDK/Data/MXRoomState.m b/MatrixSDK/Data/MXRoomState.m
@@ -120,23 +120,31 @@ + (void)loadRoomStateFromStore:(id<MXStore>)store
     {
         [store stateOfRoom:roomId success:^(NSArray<MXEvent *> * _Nonnull stateEvents) {
             if (!stateEvents.count) {
-                MXLogWarning(@"[MXRoomState] loadRoomStateFromStore(%@): No state events stored, loading from api", logId);
+                MXLogWarning(@"[MXRoomState] loadRoomStateFromStore(%@): No state events stored, loading from API", logId);
 
-                [matrixSession.matrixRestClient stateOfRoom:roomId success:^(NSArray *JSONData) {
-                    NSArray<MXEvent *> *events = [MXEvent modelsFromJSON:JSONData];
-                    MXLogDebug(@"[MXRoomState] loadRoomStateFromStore(%@): Loaded %lu events from api", logId, events.count);
-
-                    [roomState handleStateEvents:events];
-                    onComplete(roomState);
-                } failure:^(NSError *error) {
-                    NSDictionary *details = @{
-                        @"log_id": logId ?: @"unknown",
-                        @"error": error ?: @"unknown"
-                    };
-                    MXLogErrorDetails(@"[MXRoomState] loadRoomStateFromStore: Failed to load any events from api", details);
-
+                if (!matrixSession)
+                {
+                    MXLogError(@"[MXRoomState] loadRoomStateFromStore: Missing session, unable to load from API")
                     onComplete(roomState);
-                }];
+                }
+                else
+                {
+                    [matrixSession.matrixRestClient stateOfRoom:roomId success:^(NSArray *JSONData) {
+                        NSArray<MXEvent *> *events = [MXEvent modelsFromJSON:JSONData];
+                        MXLogDebug(@"[MXRoomState] loadRoomStateFromStore(%@): Loaded %lu events from api", logId, events.count);
+
+                        [roomState handleStateEvents:events];
+                        onComplete(roomState);
+                    } failure:^(NSError *error) {
+                        NSDictionary *details = @{
+                            @"log_id": logId ?: @"unknown",
+                            @"error": error ?: @"unknown"
+                        };
+                        MXLogErrorDetails(@"[MXRoomState] loadRoomStateFromStore: Failed to load any events from API", details);
+
+                        onComplete(roomState);
+                    }];
+                }
             } else {
                 MXLogDebug(@"[MXRoomState] loadRoomStateFromStore(%@): Initializing with %lu state events", logId, stateEvents.count);
 

diff --git a/changelog.d/pr-1833.bugfix b/changelog.d/pr-1833.bugfix
@@ -0,0 +1 @@
+Fix unhandled callback when the session is nil.