Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for stable MSC3882 get_login_token #1791

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

hughns
Copy link
Member

@hughns hughns commented May 31, 2023

Pull Request Checklist

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 80.64% and project coverage change: +0.01 🎉

Comparison is base (258bdb8) 35.54% compared to head (083df72) 35.55%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1791      +/-   ##
===========================================
+ Coverage    35.54%   35.55%   +0.01%     
===========================================
  Files          617      618       +1     
  Lines        97208    97235      +27     
  Branches     41489    41506      +17     
===========================================
+ Hits         34548    34572      +24     
- Misses       61768    61769       +1     
- Partials       892      894       +2     
Impacted Files Coverage Δ
MatrixSDK/MXRestClient.m 28.61% <0.00%> (ø)
...rixSDKTests/MXAuthenticationSessionUnitTests.swift 79.80% <73.33%> (-1.52%) ⬇️
MatrixSDK/JSONModels/MXJSONModels.m 29.48% <80.00%> (-0.08%) ⬇️
MatrixSDK/JSONModels/Capabilities/MXCapabilities.m 78.37% <100.00%> (+1.23%) ⬆️
MatrixSDK/JSONModels/Login/MXLoginTokenFlow.m 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant