Stop requesting room keys from other users #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have some tests that check if receiving a forwarded room key works. These claim to use the same user id, but in fact they change the user id in the last moment before the event is passed into the client. Let's change this so we're always operating with the same user id.
We never accept such room keys, so there isn't a point in requesting them.
richvdh
requested changes
Dec 16, 2022
There was a problem hiding this comment.
looks generally good to me, modulo a few suggestions/nits as below.
The logic in shouldAcceptForwardedKey seems a little bit magical and I'm not entirely convinced we have comprehensive tests for it: it might be nice to make sure we do. But I'll not insist if you need to move on to other things.
Co-authored-by: Richard van der Hoff <[email protected]>
richvdh
reviewed
Jan 6, 2023
|
Fixes: element-hq/element-web#23766 |
|
@richvdh would be worth updating the OP otherwise github won't auto-close |
…est-room-keys-from-other-users
|
I think that this has addressed all the issues and I merged |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Adding back to the merge queue after the change that I am hoping fixes the quality metrics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requesting forwarded room keys from other users is quite pointless since we don't accept them. This mainly produces unnecessary to-device traffic.
The main commit in this PR is the third one, where we finally remove the requesting of room keys from other users. The previous commits are refactors of the forwarded room key handling and unit tests validating the forwarded room key handling.
Fixes: element-hq/element-web#23766
Fixes: element-hq/element-web#24681
This change is marked as an internal change (Task), so will not be included in the changelog.