Avoid logical assignment operator #3022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently `??=` was only added to javascript in ES12, and our eleweb build doesn't support it.
andybalaam
approved these changes
Jan 4, 2023
richvdh
added a commit
to element-hq/element-web
that referenced
this pull request
Jan 4, 2023
This should fix any future problems along the lines of matrix-org/matrix-js-sdk#3022.
richvdh
added a commit
to element-hq/element-web
that referenced
this pull request
Jan 4, 2023
This should fix any future problems along the lines of matrix-org/matrix-js-sdk#3022.
odelcroi
added a commit
to tchapgouv/tchap-web-v4
that referenced
this pull request
Mar 23, 2023
* Move pin drop out of labs (PSG-664) Signed-off-by: Johannes Marbach <[email protected]> * Add prettier formatting to .git-blame-ignore-revs * Update typescript-eslint monorepo to v5.46.0 (#23990) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency @types/jest to v29.2.4 (#23989) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency @types/node to v16.18.8 (#23994) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Reset matrix-js-sdk back to develop branch * Reset matrix-react-sdk back to develop branch * Align code_style.md with prettier (#24124) * Use Identity Server v2 API for tests (#24086) * Update dependency worker-loader to v3 (#24033) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency style-loader to v3 (#24027) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency optimize-css-assets-webpack-plugin to v6 (#24010) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Downgrade to style-loader 2 to regain Webpack 4 compatibility (#24150) * Revert "Update dependency worker-loader to v3 (#24033)" This reverts commit 07bd0f1. * Bump json5 from 1.0.1 to 1.0.2 (#24148) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Explicitly set worker-loader's publicPath to webapp * Revert "Explicitly set worker-loader's publicPath to webapp" This reverts commit f5fea0b. * Re-update dependency worker-loader to v3 (#24033) This reverts commit 211de2b. * Specify the filename for worker-loader to avoid bundling workers * Configure babel to transform logical assignment (#24160) This should fix any future problems along the lines of matrix-org/matrix-js-sdk#3022. * Bump decode-uri-component from 0.2.0 to 0.2.2 (#23895) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Translations update from Weblate (#24208) * Added translation using Weblate (Breton) * Translated using Weblate (Thai) Currently translated at 100.0% (30 of 30 strings) Translation: Element Web/element-web Translate-URL: https://translate.element.io/projects/element-web/element-web/th/ * Translated using Weblate (Esperanto) Currently translated at 100.0% (30 of 30 strings) Translation: Element Web/element-web Translate-URL: https://translate.element.io/projects/element-web/element-web/eo/ * Translated using Weblate (Breton) Currently translated at 3.3% (1 of 30 strings) Translation: Element Web/element-web Translate-URL: https://translate.element.io/projects/element-web/element-web/br/ * Translated using Weblate (Armenian) Currently translated at 63.3% (19 of 30 strings) Translation: Element Web/element-web Translate-URL: https://translate.element.io/projects/element-web/element-web/hy/ Co-authored-by: jmguyader <[email protected]> Co-authored-by: pk'Mysickz <[email protected]> Co-authored-by: Christian Paul <[email protected]> Co-authored-by: Aramayis Hovhannisyan <[email protected]> Co-authored-by: Weblate <[email protected]> * Upgrade matrix-js-sdk to 23.1.0-rc.1 * Upgrade matrix-react-sdk to 3.64.0-rc.1 * Prepare changelog for v1.11.18-rc.1 * v1.11.18-rc.1 * Update babel monorepo (#24210) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update typescript-eslint monorepo to v5.48.0 (#24212) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Stow more things in element-web-develop.element.io (#23965) * Upgrade matrix-js-sdk to 23.1.0-rc.2 * Upgrade matrix-react-sdk to 3.64.0-rc.2 * Prepare changelog for v1.11.18-rc.2 * v1.11.18-rc.2 * Update dependency @types/jest to v29.2.5 (#24211) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Upgrade matrix-js-sdk to 23.1.0-rc.3 * Upgrade matrix-react-sdk to 3.64.0-rc.3 * Prepare changelog for v1.11.18-rc.3 * v1.11.18-rc.3 * Update automation for new app team board (#24219) Old board has been archived, updating automation to move issues to the new board. * Remove delight automation (#24225) * Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (30 of 30 strings) Translation: Element Web/element-web Translate-URL: https://translate.element.io/projects/element-web/element-web/pt_BR/ * Document updated default `uisi_autorageshake_app` (#24224) Documentation for matrix-org/matrix-react-sdk#9909 * Upgrade matrix-js-sdk to 23.1.0-rc.4 * Upgrade matrix-react-sdk to 3.64.0-rc.4 * Prepare changelog for v1.11.18-rc.4 * v1.11.18-rc.4 * Upgrade matrix-js-sdk to 23.1.0 * Upgrade matrix-react-sdk to 3.64.0 * Prepare changelog for v1.11.18 * v1.11.18 * Reset matrix-js-sdk back to develop branch * Reset matrix-react-sdk back to develop branch * Upgrade matrix-react-sdk to 3.64.1 * Prepare changelog for v1.11.19 * v1.11.19 * Translated using Weblate (Arabic) Currently translated at 100.0% (30 of 30 strings) Translation: Element Web/element-web Translate-URL: https://translate.element.io/projects/element-web/element-web/ar/ * Reset matrix-react-sdk back to develop branch * Reset matrix-js-sdk back to develop branch * Translated using Weblate (Hungarian) Currently translated at 100.0% (30 of 30 strings) Translation: Element Web/element-web Translate-URL: https://translate.element.io/projects/element-web/element-web/hu/ * Upgrade matrix-js-sdk to 23.1.1 * Upgrade matrix-react-sdk to 3.64.2 * Prepare changelog for v1.11.20 * v1.11.20 * Reset matrix-react-sdk back to develop branch * Reset matrix-js-sdk back to develop branch * Reset matrix-react-sdk back to develop branch * Delete triage-priority-bugs.yml (#24266) This was moving issues to a non-existent board * Translated using Weblate (Icelandic) Currently translated at 100.0% (30 of 30 strings) Translation: Element Web/element-web Translate-URL: https://translate.element.io/projects/element-web/element-web/is/ * Translations update from Weblate (#24307) * Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (30 of 30 strings) Translation: Element Web/element-web Translate-URL: https://translate.element.io/projects/element-web/element-web/pt_BR/ * Translated using Weblate (Arabic) Currently translated at 100.0% (30 of 30 strings) Translation: Element Web/element-web Translate-URL: https://translate.element.io/projects/element-web/element-web/ar/ * Translated using Weblate (Hungarian) Currently translated at 100.0% (30 of 30 strings) Translation: Element Web/element-web Translate-URL: https://translate.element.io/projects/element-web/element-web/hu/ * Translated using Weblate (Icelandic) Currently translated at 100.0% (30 of 30 strings) Translation: Element Web/element-web Translate-URL: https://translate.element.io/projects/element-web/element-web/is/ Co-authored-by: Feroli <[email protected]> Co-authored-by: Weblate <[email protected]> Co-authored-by: Ali-x98 <[email protected]> Co-authored-by: Balázs Meskó <[email protected]> Co-authored-by: Sveinn í Felli <[email protected]> * Upgrade matrix-js-sdk to 23.2.0-rc.1 * Upgrade matrix-react-sdk to 3.65.0-rc.1 * Prepare changelog for v1.11.21-rc.1 * v1.11.21-rc.1 * Update dependency ua-parser-js to v1.0.33 [SECURITY] (#24311) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Document the decoder ring (#24317) * Document the decoder ring Also a few little tidy-ups. * Prettier * Translated using Weblate (English (United States)) Currently translated at 100.0% (30 of 30 strings) Translation: Element Web/element-web Translate-URL: https://translate.element.io/projects/element-web/element-web/en_US/ * Include Janne in WAT assignment automation * Update build_develop.yml * Jitsi requests 'requires_client' capability if auth token is provided (#24294) * Jitsi requests 'io.element.requires_client' capability if auth token is provided * Added a comment that Jitsi should request 'requires_client' capability to hide the popup icon in the Element if auth token is provided. --------- Co-authored-by: Mikhail Aheichyk <[email protected]> * Upgrade matrix-js-sdk to 23.2.0 * Upgrade matrix-react-sdk to 3.65.0 * Prepare changelog for v1.11.21 * v1.11.21 * Reset matrix-js-sdk back to develop branch * Reset matrix-react-sdk back to develop branch * Prepare changelog for v1.11.22 * v1.11.22 * Update build_develop.yml * Description of QR code sign in labs feature (#23513) * Translated using Weblate (Japanese) Currently translated at 100.0% (30 of 30 strings) Translation: Element Web/element-web Translate-URL: https://translate.element.io/projects/element-web/element-web/ja/ * Update config.md - these UIFeature flags died with communities (#24428) * Upgrade matrix-js-sdk to 23.3.0-rc.1 * Upgrade matrix-react-sdk to 3.66.0-rc.1 * Prepare changelog for v1.11.23-rc.1 * v1.11.23-rc.1 * Update typescript-eslint monorepo to v5.51.0 (#24461) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update jest monorepo to v29.4.0 (#24460) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Add some advice on good PR titles (#24483) * Add some advice on good PR titles * Extra 'the' Co-authored-by: Germain <[email protected]> --------- Co-authored-by: Germain <[email protected]> * Translated using Weblate (Occitan) Currently translated at 100.0% (30 of 30 strings) Translation: Element Web/element-web Translate-URL: https://translate.element.io/projects/element-web/element-web/oc/ * Update alex-page/github-project-automation-plus digest to 7ffb872 (#24496) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * labs.md: add notes about `feature_rust_crypto` (#24488) * Update docker/build-push-action action to v4 (#24497) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Upgrade matrix-js-sdk to 23.3.0 * Upgrade matrix-react-sdk to 3.66.0 * Prepare changelog for v1.11.23 * v1.11.23 * Reset matrix-js-sdk back to develop branch * Reset matrix-react-sdk back to develop branch * Remove element home ad links * Update dependency mkdirp to v2 (#24462) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update issue automation for A-Jump-To-Date (#24553) * Don't remove Z-Labs from A-Jump-To-Date * A-Jump-To-Date should get Z-Labs * Update dependency @babel/runtime to v7.20.13 (#24458) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * yarn upgrade all eslint packages * Update webpack hash function for greater OSSL compat (#24584) * Translated using Weblate (Hebrew) Currently translated at 100.0% (30 of 30 strings) Translation: Element Web/element-web Translate-URL: https://translate.element.io/projects/element-web/element-web/he/ * Remove reference to threads in labs (#24591) * Update pull_request.yaml * Upgrade matrix-js-sdk to 23.4.0-rc.1 * Upgrade matrix-react-sdk to 3.67.0-rc.1 * Prepare changelog for v1.11.24-rc.1 * v1.11.24-rc.1 * Update dependency stylelint-config-standard to v30 (#24608) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Upgrade matrix-js-sdk to 23.4.0-rc.2 * Upgrade matrix-react-sdk to 3.67.0-rc.2 * Prepare changelog for v1.11.24-rc.2 * v1.11.24-rc.2 * Update jest monorepo to v29.4.3 (#24603) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Add issue automation for the Verticals Team (#24610) * send verticals team issues to their project * Pass current language into Jitsi (#24609 * Pass current language into Jitsi Jitsi itself now uses the current language of the user. However, this does not yet apply to the welcome page of the Jitsi widget that says "Join conference", which is only hard-coded to english for now. Signed-off-by: Oliver Sand <[email protected]> * Map between Element and Jitsi language codes --------- Signed-off-by: Oliver Sand <[email protected]> * Update definitelyTyped (#24562) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix frame-ancestors docs from none to self to not break Jitsi (#21128) * Update babel monorepo to v7.21.0 (#24633) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Remove Firefox and Safari from experimental PWA support (#24630) * yarn upgrade jest * Translated using Weblate (Georgian) Currently translated at 100.0% (30 of 30 strings) Translation: Element Web/element-web Translate-URL: https://translate.element.io/projects/element-web/element-web/ka/ * Pull reviews bot automation for Web App Team room (#24679) * Upgrade matrix-js-sdk to 23.4.0 * Upgrade matrix-react-sdk to 3.67.0 * Prepare changelog for v1.11.24 * v1.11.24 * Reset matrix-js-sdk back to develop branch * Reset matrix-react-sdk back to develop branch * Update typescript-eslint monorepo to v5.53.0 (#24634) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update yarn.lock (#24696) * Update yarn.lock * iterate * Iterate * Resolutions * Iterate * Apply resolution for @types/react * Depend on a non-broken version of matrix-react-sdk (#24708) * Upgrade our eslint config to the latest (#24647) * Fix lint error in test-utils.ts * Upgrade eslint config (and separate projects to support it) * Handle possibility that req.error could be null * Drop hosting docs * Bump @matrix-org/react-sdk-module-api to 0.0.4 (#24642) * Bump @matrix-org/react-sdk-module-api to 0.0.4 * Move to latest matrix-react-sdk and yarn install to change react-sdk-module-api version * Undo accidental change to matrix-react-sdk version * One more yarn install * Update dependency stylelint to v15 (#24607) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update all non-major dependencies (#24005) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Remove items incorrectly included in changelog for 1.11.24 (#24732) * Translated using Weblate (Chinese (Traditional)) Currently translated at 100.0% (30 of 30 strings) Translation: Element Web/element-web Translate-URL: https://translate.element.io/projects/element-web/element-web/zh_Hant/ * package.json: Remove --host override (#24736) Most people probably only want the dev server to listen on localhost. Additionally, overriding with `--host 0.0.0.0` here prevents passing a different value for `--host` to yarn. For example: ``` $ yarnpkg start:js --host=:: yarn run v1.22.19 $ webpack-dev-server --host=0.0.0.0 --output-filename=bundles/_dev_/[name].js --output-chunk-filename=bundles/_dev_/[name].js -w --mode development --disable-host-check --hot --host=:: Unset VERSION variable - this may affect build output ✖ ｢wds｣: webpack Dev Server Invalid Options options.host should be {String|Null} (https://webpack.js.org/configuration/dev-server/#devserverhost) error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. ``` * Upgrade matrix-js-sdk to 23.5.0-rc.1 * Upgrade matrix-react-sdk to 3.68.0-rc.1 * Prepare changelog for v1.11.25-rc.1 * v1.11.25-rc.1 * Upgrade matrix-react-sdk to 3.68.0-rc.2 * Prepare changelog for v1.11.25-rc.2 * v1.11.25-rc.2 * Upgrade matrix-react-sdk to 3.68.0-rc.3 * Prepare changelog for v1.11.25-rc.3 * v1.11.25-rc.3 * Upgrade matrix-js-sdk to 23.5.0 * Upgrade matrix-react-sdk to 3.68.0 * Prepare changelog for v1.11.25 * v1.11.25 * Resolve conflit between Tchap and Element Web 1.11.25 (#475) * Resolve conflit between Tchap and Element Web 1.11.25 * Add patch-package to package.json * Move patches temporary to other path * Remove unnecessary patch * Fix patch-package position in package.json * Move back patches-unfixed to patches * Add merge script * Adaptation of 15 patches * Update merge Script * Adapt Hide Location patch * Remove patch user-friendlier-encrypted-messages * activate-cross-signing-and-secure-storage-react - to test : checkDeviceTrust without isCrossSigningSupported * add-a-help-tab-in-menu-to-redirect-to-external-tchap-faq * remove old patch activate-cross-signing-and-secure-storage-react * patch : auto-accept-tac * update patch better-help-settings * update patch : cross signing ui * patch update : disable-access-options * update patch : forgot-password, removed one file from patch * remove old patch : hide-location-if-no-map-server * update patch : login * Adapt patch simplify-exchange-key-message * update patch : password-policy * restore Tchap configuration in package json * remove lint error * change version to 4.2.0 * remove conf files from eslint * reactivate patches in package --------- Co-authored-by: olivier <[email protected]> * Remove threads buttons (#478) * Remove threads buttons * Add patch name to deactivate threads in patches.json and hide a new occurrence of thread in MessageActionBar * Test: fix bug-web file * Fix enhancement.yml indent --------- Co-authored-by: Audrey Lambert <[email protected]> * replace reinitialization button in unlock error message (#488) * add DecryptionFailureBar to patch cross-signing-ui * update messages * revert lint config * move not used yaml * revert indentation + missing props * revert parseerOptions project * remove unused languages --------- Signed-off-by: Johannes Marbach <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Oliver Sand <[email protected]> Co-authored-by: Johannes Marbach <[email protected]> Co-authored-by: Michael Weimann <[email protected]> Co-authored-by: Andy Balaam <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: RiotRobot <[email protected]> Co-authored-by: Travis Ralston <[email protected]> Co-authored-by: Robin <[email protected]> Co-authored-by: Germain <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andy Balaam <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]> Co-authored-by: Element Translate Bot <[email protected]> Co-authored-by: jmguyader <[email protected]> Co-authored-by: pk'Mysickz <[email protected]> Co-authored-by: Christian Paul <[email protected]> Co-authored-by: Aramayis Hovhannisyan <[email protected]> Co-authored-by: Weblate <[email protected]> Co-authored-by: Michael Telatynski <[email protected]> Co-authored-by: Kat Gerasimova <[email protected]> Co-authored-by: Germain <[email protected]> Co-authored-by: Feroli <[email protected]> Co-authored-by: Ali-x98 <[email protected]> Co-authored-by: Balázs Meskó <[email protected]> Co-authored-by: Sveinn í Felli <[email protected]> Co-authored-by: David Baker <[email protected]> Co-authored-by: theamazing0 <[email protected]> Co-authored-by: maheichyk <[email protected]> Co-authored-by: Mikhail Aheichyk <[email protected]> Co-authored-by: Hugh Nimmo-Smith <[email protected]> Co-authored-by: Suguru Hirahara <[email protected]> Co-authored-by: Walter Bulbazor <[email protected]> Co-authored-by: Half-Shot <[email protected]> Co-authored-by: kojedra <[email protected]> Co-authored-by: David Langley <[email protected]> Co-authored-by: Oliver Sand <[email protected]> Co-authored-by: Dragonidze <[email protected]> Co-authored-by: Open Culture Foundation <[email protected]> Co-authored-by: Val Lorentz <[email protected]> Co-authored-by: Julien DAUPHANT <[email protected]> Co-authored-by: Julien DAUPHANT <[email protected]> Co-authored-by: Audrey Lambert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently
??=was only added to javascript in ES12, and our eleweb builddoesn't support it.
Fixes breakage introduced in #3019.
This change is marked as an internal change (Task), so will not be included in the changelog.