Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't share full key history for RTC per-participant encryption #4406

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

hughns
Copy link
Member

@hughns hughns commented Sep 13, 2024

Instead we only share what is needed.

This PR also records stats for how many keys have been sent/received and age of those received.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Also record stats for how many keys have been sent/received and age of those received
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand what the 'total age' statistic is there for (wouldn't it be more useful to know say, the max, min, and average age?) but as long as you have a use case for it in mind, this looks fine.

src/matrixrtc/MatrixRTCSession.ts Outdated Show resolved Hide resolved
@hughns
Copy link
Member Author

hughns commented Sep 18, 2024

I don't fully understand what the 'total age' statistic is there for (wouldn't it be more useful to know say, the max, min, and average age?) but as long as you have a use case for it in mind, this looks fine.

The total age is there to calculate the average age later on. I've improved the comment to explain this. 👍

@hughns hughns added this pull request to the merge queue Sep 18, 2024
Merged via the queue into develop with commit 414ac9d Sep 18, 2024
26 checks passed
@hughns hughns deleted the hughns/rtc-sender-key-stats branch September 18, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants