Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MSC2762 update_state widget action when running as embedded client #4662

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

hughns
Copy link
Member

@hughns hughns commented Jan 27, 2025

Implements #4665

This change enables room widget clients to take advantage of the more reliable method of communicating room state over the widget API provided by a recent update to MSC2762.

This capability was originally introduced in #4574 but then reverted in #4656 as it was not backwards compatible.

This PR should maintain compatibility so that embedded RoomWidgetClient will continue to work with widget container/hosts irrespective if they support the recent update to MSC2762.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

robintown and others added 4 commits January 27, 2025 17:06
* Distinguish room state and timeline events in embedded clients

This change enables room widget clients to take advantage of the more reliable method of communicating room state over the widget API provided by a recent update to MSC2762.

* Add missing awaits

* Upgrade matrix-widget-api
@hughns hughns changed the title Distinguish room state and timeline events in embedded clients (#4574) Distinguish room state and timeline events in embedded clients Jan 27, 2025
@hughns hughns changed the title Distinguish room state and timeline events in embedded clients Support for update_state widget action when running as embedded client Jan 27, 2025
@hughns hughns changed the title Support for update_state widget action when running as embedded client Support for MSC2762 update_state widget action when running as embedded client Jan 27, 2025
Copy link
Member Author

@hughns hughns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • getClientVersions() needs mocking
  • test case needed for when update_state is not supported by widget host
  • test case needed for when update_state is supported by widget host

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants