Skip to content

Use the logger associated with MatrixClient in rust sdk #4918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jul 11, 2025

Currently, all the logging from the rust crypto sdk goes to console, regardless of whether a logger as passed to the MatrixClient. This fixes that problem.

@richvdh richvdh added T-Feature Request to add a new feature which does not exist right now T-Enhancement and removed T-Feature Request to add a new feature which does not exist right now labels Jul 11, 2025
@richvdh richvdh force-pushed the rav/rust_crypto_use_js_logger branch from a67efa4 to 70c69c0 Compare July 24, 2025 16:35
@richvdh richvdh marked this pull request as ready for review July 24, 2025 16:47
@richvdh richvdh requested a review from a team as a code owner July 24, 2025 16:47
@richvdh richvdh requested review from andybalaam and uhoreg July 24, 2025 16:47
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@richvdh richvdh added this pull request to the merge queue Jul 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 25, 2025
@richvdh richvdh added this pull request to the merge queue Jul 25, 2025
Merged via the queue into develop with commit 812d0aa Jul 25, 2025
36 checks passed
@richvdh richvdh deleted the rav/rust_crypto_use_js_logger branch July 25, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants