Skip to content

do not set cache in authenticated fetch #5020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

do not set cache in authenticated fetch #5020

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b4f966c
do not set cache in authenticated fetch
Sep 27, 2025
afc11dc
issue 5019 - updated comment
Sep 27, 2025
e76b1e6
do not set cache in authenticated fetch
Sep 27, 2025
f6df7d3
issue 5019 - updated comment
Sep 27, 2025
898dbdd
Merge branch 'fix_issue_5019_default_cache_in_authed_fetch' of https:…
pkuzco Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/http-api/fetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,13 @@ export class FetchHttpApi<O extends IHttpOpts> {

const { signal, cleanup } = anySignal(signals);

// Set cache mode based on presence of Authorization header.
// Browsers/proxies do not cache responses to requests with Authorization headers.
// So specifying "no-cache" is redundant, and actually prevents caching
// of preflight requests in CORS scenarios. As such, we only set "no-cache"
// when there is no Authorization header.
const cacheMode = "Authorization" in headers ? undefined : "no-cache";

let res: Response;
const start = Date.now();
try {
Expand All @@ -291,7 +298,7 @@ export class FetchHttpApi<O extends IHttpOpts> {
redirect: "follow",
referrer: "",
referrerPolicy: "no-referrer",
cache: "no-cache",
cache: cacheMode,
credentials: "omit", // we send credentials via headers
keepalive: keepAlive,
priority: opts.priority,
Expand Down
Loading