-
-
Notifications
You must be signed in to change notification settings - Fork 642
[MatrixRTC] Use relation based call membership to compute create_ts()
#5031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
[MatrixRTC] Use relation based call membership to compute create_ts()
#5031
Conversation
Signed-off-by: Timo K <[email protected]>
- rename Focus -> Transport - add RtcMembershipData (next to `sessionMembershipData`) - make `new CallMembership` initializable with both - move oldest member calculation into CallMembership Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Co-authored-by: Robin <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
9e977fb
to
aa1cbe9
Compare
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
c5df193
to
e9dafb5
Compare
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
create_ts()
create_ts()
create_ts()
Signed-off-by: Timo K <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if two MatrixRTCSession.sessionMembershipsForSlot are running at the same time?
The second one could finish before the other.... Is this an issue?
@toger5 Is the diff meant to be as big as it is? I think I'm looking at a lot of lint fixes, or something. |
On top of this, the construct for callMembership has a signature change which requires a change in before |
This PR changes the construction of the
CallMembership
object.It will add an optional
relatedEvent
parameter which will store initial connect event for this call participation.This is then used to fetch metadata (like
application
) and theorigin_server_ts
of the initial join event.This requires that
MatrixRTCSession.sessionMembershipsForSlot
becomes async since it now also needs to fetch related events.This change needs a bit of test adjustments and other places of the codebase need updating.
Checklist
public
/exported
symbols have accurate TSDoc documentation.