Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add data attribute to know what header is used #11735

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Add data attribute to know what header is used #11735

merged 3 commits into from
Oct 12, 2023

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Oct 11, 2023 •
edited by github-actions bot
Loading

Related to element-hq/element-desktop#1245
To review alongside with element-hq/element-desktop#1272

Asking for a test exemption here. This is very temporary and only needed during the transition period.

Used to implement the negative space in electron.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@germain-gg germain-gg added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 11, 2023
@germain-gg germain-gg mentioned this pull request Oct 11, 2023
Merged
3 tasks
@germain-gg germain-gg marked this pull request as ready for review October 11, 2023 17:02
@germain-gg germain-gg requested a review from a team as a code owner October 11, 2023 17:02
kerryarchibald
kerryarchibald approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine! One nit: I know it's temporary, but could we read the setting just once at the top of render instead?

@germain-gg germain-gg enabled auto-merge October 12, 2023 07:40
@germain-gg germain-gg added this pull request to the merge queue Oct 12, 2023
Merged via the queue into develop with commit 9ea04a5 Oct 12, 2023
19 checks passed
@germain-gg germain-gg deleted the germain-gg/electron-negative-space branch October 12, 2023 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kerryarchibald kerryarchibald kerryarchibald approved these changes

@richvdh richvdh Awaiting requested review from richvdh richvdh is a code owner automatically assigned from matrix-org/element-web-reviewers

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@germain-gg @kerryarchibald