Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "Manually verify all remote sessions" setting #12706

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Jun 27, 2024

And remove all of the advanced encryption settings section, since that was the only setting in there.

fixes element-hq/element-web#27613

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

And remove all of the advanced encryption settings section, since that was the
only setting in there.
@uhoreg uhoreg requested a review from a team as a code owner June 27, 2024 03:35
@uhoreg uhoreg added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jun 27, 2024
// show up and can't be toggled. PushToMatrixClientController doesn't
// do any overrides anyways.
new UIFeatureController(UIFeature.AdvancedEncryption),
new PushToMatrixClientController(MatrixClient.prototype.setCryptoTrustCrossSignedDevices, true),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could also remove OrderedMultiController and PushToMatrixClientController since this is the only place that uses them, I suppose.

@uhoreg uhoreg added this pull request to the merge queue Jul 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 3, 2024
@uhoreg uhoreg added this pull request to the merge queue Jul 12, 2024
Merged via the queue into matrix-org:develop with commit db95f26 Jul 12, 2024
26 checks passed
@uhoreg uhoreg deleted the remove_manually_verify_sessions branch July 12, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Manually verify all remote sessions" does nothing
3 participants