This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Rich text Editor: Auto-replace plain text emoticons with emoji #12828
+184
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modes of the RTE.
langleyd
added
the
T-Enhancement
…matrix-org/matrix-react-sdk into langleyd/rte_auto_replace_emoji
dbkr
approved these changes
Aug 2, 2024
| @@ -52,6 +53,19 @@ export function PlainTextComposer({ | |||
| rightComponent, | |||
| eventRelation, | |||
| }: PlainTextComposerProps): JSX.Element { | |||
| const [isAutoReplaceEmojiEnabled, setIsAutoReplaceEmojiEnabled] = useState( | |||
| SettingsStore.getValue<boolean>("MessageComposerInput.autoReplaceEmoji"), | |||
There was a problem hiding this comment.
I believe there's also useSettingValue to do the getting + watching + unsubscribing for you
There was a problem hiding this comment.
Ah I actually looked for something as such, obviously not hard enough. 😂 thanks Dave
| @@ -61,9 +68,26 @@ export const WysiwygComposer = memo(function WysiwygComposer({ | |||
| const autocompleteRef = useRef<Autocomplete | null>(null); | |||
|
|
|||
| const inputEventProcessor = useInputEventProcessor(onSend, autocompleteRef, initialContent, eventRelation); | |||
|
|
|||
| const [emojiSuggestions, setEmojiSuggestions] = useState( | |||
| getEmojiSuggestions(SettingsStore.getValue<boolean>("MessageComposerInput.autoReplaceEmoji")), | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on matrix-org/matrix-rich-text-editor#1009
What it looks like
Screen.Recording.2024-07-25.at.19.58.54.mov