Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Crash: rust model panic during getMarkdown() #838

Closed
bmarty opened this issue Oct 6, 2023 · 0 comments · Fixed by #846
Closed

Crash: rust model panic during getMarkdown() #838

bmarty opened this issue Oct 6, 2023 · 0 comments · Fixed by #846

Comments

@bmarty
Copy link
Contributor

bmarty commented Oct 6, 2023

Problem

Calling getMarkdown() may cause a crash if the underlying Rust model panics.

Please see the details in

Solution

  • Catch and track any rust panic during getMarkdown() method (perhaps others too).
  • Fall back to get_content_as_plain_text() if getMarkdown() fails.
  • Fall back to empty string if get_content_as_plain_text() fails.
@jonnyandrew jonnyandrew changed the title Crash from Element X Android Crash: rust model panic during getMarkdown() Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants