Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

[Android] Handle and track more internal exceptions #846

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Oct 16, 2023

Problem

Functions that call the underlying rust model may fail due to rust panics.

Solution

Wrap any such functions in try-catch blocks that log and recover from any unexpected errors.

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonnyandrew jonnyandrew requested a review from a team October 16, 2023 15:38
@codecov-commenter
Copy link

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (cb43c9e) 89.93% compared to head (02cdd1f) 87.78%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #846      +/-   ##
============================================
- Coverage     89.93%   87.78%   -2.16%     
- Complexity        0      369     +369     
============================================
  Files           114      129      +15     
  Lines         16331    16654     +323     
  Branches        631      368     -263     
============================================
- Hits          14688    14619      -69     
- Misses         1620     1788     +168     
- Partials         23      247     +224     
Flag Coverage Δ
uitests 65.92% <29.16%> (-13.24%) ⬇️
uitests-android 65.92% <29.16%> (?)
uitests-ios ?
unittests 87.16% <22.91%> (-1.51%) ⬇️
unittests-android 44.30% <22.91%> (?)
unittests-ios ?
unittests-rust 89.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...roid/wysiwyg/internal/viewmodel/EditorViewModel.kt 48.82% <31.25%> (ø)

... and 78 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonnyandrew jonnyandrew merged commit cb9644b into main Oct 27, 2023
10 checks passed
@jonnyandrew jonnyandrew deleted the jonny/fix-crashes branch October 27, 2023 08:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash: rust model panic during getMarkdown()
3 participants