Fix lib type export #1013
Fix lib type export #1013
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1013 +/- ##
==========================================
- Coverage 90.32% 89.53% -0.79%
==========================================
Files 177 104 -73
Lines 21173 17990 -3183
Branches 280 280
==========================================
- Hits 19124 16107 -3017
+ Misses 2046 1880 -166
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -34,6 +34,7 @@ export default defineConfig({ | |||
| 'lib/types.ts', | |||
| 'lib/constants.ts', | |||
| 'lib/useListeners/types.ts', | |||
| 'lib/useTestCases/types.ts', | |||
There was a problem hiding this comment.
Hmmm, why do we need to export a type used in test cases?
There was a problem hiding this comment.
Yea, its a bit weird that the function in question I think just returns this type so that we can unit test it.
At a high level you are right though, the app code shouldn't depend on the test code. I'll move the type to the app code to switch this around.
|
TraceActionwasn't exported so the last release broke the renovate PR on react-sdk.