Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Xcode 15.4 support #1020

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Xcode 15.4 support #1020

merged 2 commits into from
Jul 16, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jul 16, 2024

No description provided.

@Velin92 Velin92 added the iOS label Jul 16, 2024
@Velin92 Velin92 requested a review from pixlwave July 16, 2024 15:13
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.19%. Comparing base (6a1960d) to head (04c7f47).
Report is 4 commits behind head on main.

Files Patch % Lines
...ample/WysiwygUITests/WysiwygUITests+Keyboard.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
- Coverage   90.28%   90.19%   -0.09%     
==========================================
  Files         179      179              
  Lines       21474    21474              
  Branches      280      280              
==========================================
- Hits        19387    19369      -18     
- Misses       2084     2102      +18     
  Partials        3        3              
Flag Coverage Δ
uitests 84.61% <0.00%> (-1.08%) ⬇️
uitests-ios 84.61% <0.00%> (-1.08%) ⬇️
unittests 89.27% <ø> (+0.03%) ⬆️
unittests-ios 87.57% <ø> (+0.25%) ⬆️
unittests-react 88.66% <ø> (ø)
unittests-rust 89.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

also removed the forcing software keyboard, since now it's automatically forced on 15.4 every run.
Copy link

sonarcloud bot commented Jul 16, 2024

@Velin92 Velin92 merged commit f407db4 into main Jul 16, 2024
7 checks passed
@Velin92 Velin92 deleted the mauroromito/update_for_xcode_15_4 branch July 16, 2024 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants