Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Escape text in links and mentions for wasm bindings #1032

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

langleyd
Copy link
Contributor

Escape text in links and mentions for wasm bindings

Same as #988 but for wasm

@langleyd langleyd added the Web label Aug 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.42%. Comparing base (e8b5f33) to head (4fa23e8).

Files Patch % Lines
bindings/wysiwyg-wasm/src/lib.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
- Coverage   90.09%   89.42%   -0.68%     
==========================================
  Files         179      104      -75     
  Lines       21630    18152    -3478     
  Branches      291      291              
==========================================
- Hits        19488    16232    -3256     
+ Misses       2139     1917     -222     
  Partials        3        3              
Flag Coverage Δ
uitests ?
uitests-ios ?
unittests 89.42% <0.00%> (+0.24%) ⬆️
unittests-ios ?
unittests-react 88.92% <ø> (ø)
unittests-rust 89.50% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@langleyd
Copy link
Contributor Author

js_sys::Map couldn't be instantiated within the lib.rs tests as it's outside of a wasm context. Not sure how to work around this, so wrote the test in typescript to cover it.

Copy link

sonarcloud bot commented Aug 28, 2024

@langleyd langleyd merged commit 2d8f0c7 into main Aug 28, 2024
7 checks passed
@langleyd langleyd deleted the langleyd/wasm_escape_text_in_mentions_and_links branch August 28, 2024 12:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants