Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Add docs to example format selection writer #701

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

jonnyandrew
Copy link
Contributor

Changes

  • Add documentation to example format selection writer (used in tests)
  • Improve naming within selection writer code

Context

This part of the code base has caused some confusion for a maintainers including myself and could do with refactoring. As a stop-gap I've clarified some of the naming and added documentation.

@jonnyandrew jonnyandrew requested a review from a team June 1, 2023 09:18
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.62 🎉

Comparison is base (9d6b58c) 88.12% compared to head (2c222b0) 89.74%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #701      +/-   ##
============================================
+ Coverage     88.12%   89.74%   +1.62%     
============================================
  Files           143       78      -65     
  Lines         16291    13590    -2701     
  Branches        762        0     -762     
============================================
- Hits          14356    12197    -2159     
+ Misses         1753     1393     -360     
+ Partials        182        0     -182     
Flag Coverage Δ
uitests ?
uitests-android ?
uitests-ios ?
unittests 89.74% <100.00%> (+2.07%) ⬆️
unittests-android ?
unittests-ios ?
unittests-rust 89.74% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rates/wysiwyg/src/composer_model/example_format.rs 97.59% <100.00%> (ø)

... and 65 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@artcodespace artcodespace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, could have used this yesterday afternoon!

@artcodespace
Copy link
Contributor

Hang on a minute - code cov is showing an improvement. Something fishy there.

@jonnyandrew
Copy link
Contributor Author

jonnyandrew commented Jun 1, 2023

Hang on a minute - code cov is showing an improvement. Something fishy there.

@alunturner I suspect it's something related to the fact that Android and iOS tests are not running here but they are on the main branch. I have created an issue:

@jonnyandrew jonnyandrew merged commit 0ef2a75 into main Jun 1, 2023
@jonnyandrew jonnyandrew deleted the jonny/selection-writer-docs branch June 1, 2023 13:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants