Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Update Android to use new mention insertion APIs #706

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Update Android to use new mention insertion APIs #706

merged 2 commits into from
Jun 12, 2023

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Jun 5, 2023 •
edited
Loading

Changes

  • Update Android library to use mention insertion API added in Add mention insertion methods #698
  • Ensure character index mapping between the editor UI and composer model works. As mentions are treated as a single character in the Rust model, we can achieve this by by marking all but one character of the mention anchor text with ExtraCharacterSpans so that they are not counted.

Context

@jonnyandrew jonnyandrew marked this pull request as ready for review June 6, 2023 15:17
@jonnyandrew jonnyandrew requested a review from a team June 6, 2023 15:18
artcodespace
artcodespace approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@artcodespace artcodespace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I wonder if we should hold merge until the target branch is approved though?

@artcodespace artcodespace merged commit cd8b839 into alunturner/add-mention-insertion-methods Jun 12, 2023
@artcodespace artcodespace deleted the jonny/android-mention-insertion branch June 12, 2023 08:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@artcodespace artcodespace artcodespace approved these changes

Assignees
No one assigned
Labels
Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonnyandrew @artcodespace