Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Fix codeblock parsing #738

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Fix codeblock parsing #738

merged 2 commits into from
Jun 30, 2023

Conversation

artcodespace
Copy link
Contributor

@artcodespace artcodespace commented Jun 30, 2023

Fixes #493 (the codeblock part).

Integrating this into element web (PR still to be opened) will fix the list issue in the linked issue above.

@artcodespace artcodespace requested a review from a team June 30, 2023 08:25
@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.26 ⚠️

Comparison is base (244d6db) 90.20% compared to head (222faca) 89.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
- Coverage   90.20%   89.95%   -0.26%     
==========================================
  Files         113       83      -30     
  Lines       16034    14598    -1436     
  Branches      565        0     -565     
==========================================
- Hits        14464    13131    -1333     
+ Misses       1550     1467      -83     
+ Partials       20        0      -20     
Flag Coverage Δ
uitests ?
uitests-ios ?
unittests 89.95% <100.00%> (+0.98%) ⬆️
unittests-ios ?
unittests-rust 89.95% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...yg/src/dom/parser/markdown/markdown_html_parser.rs 100.00% <100.00%> (ø)

... and 30 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artcodespace artcodespace merged commit 61cdc44 into main Jun 30, 2023
@artcodespace artcodespace deleted the alunturner/fix-codeblock-parsing branch June 30, 2023 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lists] [Code blocks] Converting between html and markdown is not consistent
3 participants