This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
Allow markdown in message format #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
==========================================
- Coverage 89.95% 89.94% -0.01%
==========================================
Files 83 83
Lines 14598 14678 +80
==========================================
+ Hits 13131 13202 +71
- Misses 1467 1476 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
added 13 commits
July 10, 2023 15:13
artcodespace
force-pushed
the
alunturner/allow-markdown-in-message-format
branch
from
43d6440
to
b7b5ba5
Compare
|
Kudos, SonarCloud Quality Gate passed! |
aringenbach
approved these changes
Jul 13, 2023
| @@ -669,8 +669,9 @@ where | |||
| &self, | |||
| buffer: &mut S, | |||
| options: &MarkdownOptions, | |||
| as_message: bool, | |||
There was a problem hiding this comment.
Could be done later, but maybe it makes more sense to use a context enum for this to make it clearer what the options are. 🤔
There was a problem hiding this comment.
Yeah I think that's a fair point, although perhaps that would make sense to do that work if/when the number of formats that could be output extends past two?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work brings the markdown output in line with html output and allows the client to get markdown either for the composer (in which case it will keep mentions as html) or for a message (in which case it will format the mentions as it currently does). I believe that the changes will also help us to unbreak the iOS implementation of mentions in plain text mode.
This PR:
get_content_as_message_markdownas_messageargument through calls to functions that render the model as markdown