Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Set DTCoreText version to 1.6.26 #743

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

aringenbach
Copy link
Contributor

Set DTCoreText version down to 1.6.26 because:

  • For some reason version 1.6.27 is not officially "released" on GitHub
  • Integration tests have shown that attributed strings created with 1.6.27, tend to have more runs than those created with 1.6.26 (supposedly less runs means more performance)
  • And also this doesn't seem to break anything else than not having access to DTDefaultFontDescriptor anymore

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3a4686f) 90.17% compared to head (0522201) 90.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #743   +/-   ##
=======================================
  Coverage   90.17%   90.17%           
=======================================
  Files         113      113           
  Lines       16120    16122    +2     
  Branches      565      565           
=======================================
+ Hits        14536    14538    +2     
  Misses       1563     1563           
  Partials       21       21           
Flag Coverage Δ
uitests 82.34% <100.00%> (+0.02%) ⬆️
uitests-ios 82.34% <100.00%> (+0.02%) ⬆️
unittests 89.09% <100.00%> (+0.02%) ⬆️
unittests-ios 80.47% <100.00%> (+0.30%) ⬆️
unittests-rust 89.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ysiwygComposer/Sources/HTMLParser/HTMLParser.swift 92.94% <100.00%> (+0.17%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aringenbach aringenbach merged commit 308b774 into main Jul 21, 2023
9 checks passed
@aringenbach aringenbach deleted the aringenbach/set-dtcoretext-version branch July 21, 2023 10:27
pixlwave added a commit that referenced this pull request Jul 3, 2024
We're specifically pinning to 1.6.26, see #743 for more info.
pixlwave added a commit that referenced this pull request Jul 3, 2024
We're specifically pinning to 1.6.26, see #743 for more info.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants