This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Set WysiwygComposerView as MainActor #748

Closed

aringenbach wants to merge 1 commit into main from aringenbach/composer_view_main_actor

Contributor

aringenbach commented Jul 25, 2023

Might fix/silence some SwiftUI warnings about Publishing properties.
Issue seems to be with the focused property of the model but it's called from this view's context:

        public func textViewDidBeginEditing(_ textView: UITextView) {
            focused.wrappedValue = true
        }
        
        public func textViewDidEndEditing(_ textView: UITextView) {
            focused.wrappedValue = false
        }


          Set WysiwygComposerView as MainActor

b93ce3d

aringenbach added the iOS label

aringenbach requested a review from a team

July 25, 2023 15:19

langleyd approved these changes

View reviewed changes

Contributor

langleyd left a comment

👍

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

aringenbach marked this pull request as draft

July 25, 2023 15:34

Contributor Author

aringenbach commented Jul 25, 2023

Oh well, looks like UI tests are unhappy with this change, I'll put this on draft for now.

Contributor Author

aringenbach commented Aug 11, 2023

Issue should be fixed with #761

aringenbach closed this

aringenbach deleted the aringenbach/composer_view_main_actor branch

August 11, 2023 13:37

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

iOS