Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Use library path and clear most of the UDL file #749

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

aringenbach
Copy link
Contributor

This is an easy first step towards getting rid of the UDL file and use uniffi attributes to generate the bindings code.
Mostly checking that CI is happy with that change.

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Patch coverage: 31.57% and project coverage change: -0.10% ⚠️

Comparison is base (710228c) 88.34% compared to head (1cfc1d5) 88.24%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #749      +/-   ##
============================================
- Coverage     88.34%   88.24%   -0.10%     
  Complexity      268      268              
============================================
  Files           147      147              
  Lines         17430    17449      +19     
  Branches        789      789              
============================================
  Hits          15398    15398              
- Misses         1841     1860      +19     
  Partials        191      191              
Flag Coverage Δ
uitests 73.65% <ø> (ø)
uitests-android 64.10% <ø> (ø)
uitests-ios 82.34% <ø> (ø)
unittests 88.10% <31.57%> (-0.11%) ⬇️
unittests-android 58.82% <ø> (ø)
unittests-ios 80.47% <ø> (ø)
unittests-rust 89.83% <31.57%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
bindings/wysiwyg-ffi/src/ffi_composer_model.rs 27.18% <0.00%> (-0.36%) ⬇️
bindings/wysiwyg-ffi/src/ffi_composer_state.rs 0.00% <0.00%> (ø)
bindings/wysiwyg-ffi/src/ffi_composer_update.rs 96.99% <0.00%> (-1.27%) ⬇️
bindings/wysiwyg-ffi/src/ffi_dom_creation_error.rs 0.00% <0.00%> (ø)
bindings/wysiwyg-ffi/src/ffi_link_actions.rs 0.00% <0.00%> (ø)
bindings/wysiwyg-ffi/src/ffi_text_update.rs 0.00% <0.00%> (ø)
bindings/wysiwyg-ffi/src/lib.rs 0.00% <0.00%> (ø)
bindings/wysiwyg-ffi/src/ffi_action_state.rs 75.00% <100.00%> (-10.72%) ⬇️
bindings/wysiwyg-ffi/src/ffi_composer_action.rs 50.00% <100.00%> (-1.43%) ⬇️
bindings/wysiwyg-ffi/src/ffi_menu_action.rs 84.61% <100.00%> (-7.06%) ⬇️
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aringenbach aringenbach requested a review from a team July 26, 2023 09:06
@aringenbach aringenbach changed the title Use library path to generate bindings Use library path and clear most of the UDL file Jul 26, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@jonnyandrew jonnyandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

};


namespace wysiwyg_composer {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@aringenbach aringenbach merged commit 2f66a99 into main Jul 27, 2023
7 checks passed
@aringenbach aringenbach deleted the aringenbach/move_to_library_path branch July 27, 2023 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants