Fix delete word not replacing text

[aringenbach]

Should fix #808

I couldn't explore potential Web related corner cases so it might be better if a Web developer is available to double check this.

[codecov-commenter]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (90754f6) 88.38% compared to head (f2474c4) 89.91%.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #833      +/-   ##
============================================
+ Coverage     88.38%   89.91%   +1.52%     
============================================
  Files           157       82      -75     
  Lines         18104    14767    -3337     
  Branches        945        0     -945     
============================================
- Hits          16002    13278    -2724     
+ Misses         1853     1489     -364     
+ Partials        249        0     -249     

Flag	Coverage Δ
uitests	?
uitests-android	?
uitests-ios	?
unittests	89.91% <100.00%> (+3.24%)	⬆️
unittests-android	?
unittests-ios	?
unittests-rust	89.91% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
crates/wysiwyg/src/composer_model/delete_text.rs	97.41% <100.00%> (ø)

... and 75 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[jonnyandrew]

Thanks for the PR @aringenbach.

I couldn't explore potential Web related corner cases so it might be better if a Web developer is available to double check this.

I wonder if @florianduros / @andybalaam could help with this?

[florianduros]

Thanks for the PR @aringenbach.

I couldn't explore potential Web related corner cases so it might be better if a Web developer is available to double check this.

I wonder if @florianduros / @andybalaam could help with this?

I tested on Macos (Option + Delete shortcut) and it doesn't work on multiple lines:

Enregistrement.de.l.ecran.2023-10-11.a.15.31.53.mov

[aringenbach]

I tested on Macos (Option + Delete shortcut) and it doesn't work on multiple lines:

Yeah I actually tested a bit in the meantime (on Chrome & Safari for MacOS) and it looks like a few whacky things are happening with the delete word feature both with or without this change.
I think the Rust change here makes sense from the model perspective, but it seems like there might be some tidying up to do around the entire feature that might be out of my current level of expertise 🧐