Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Add inputType to RichTextEditor to allow auto capitalisation #879

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

jmartinesp
Copy link
Contributor

Fixes #826.

@jmartinesp jmartinesp requested a review from a team November 20, 2023 07:26
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c698b1b) 87.43% compared to head (b396781) 87.27%.

Files Patch % Lines
.../element/android/wysiwyg/compose/RichTextEditor.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #879      +/-   ##
============================================
- Coverage     87.43%   87.27%   -0.16%     
  Complexity      406      406              
============================================
  Files           165      133      -32     
  Lines         18956    17358    -1598     
  Branches       1045      404     -641     
============================================
- Hits          16575    15150    -1425     
+ Misses         2087     1937     -150     
+ Partials        294      271      -23     
Flag Coverage Δ
uitests 65.48% <66.66%> (-5.61%) ⬇️
uitests-android 65.48% <66.66%> (+<0.01%) ⬆️
uitests-ios ?
unittests 86.64% <ø> (+1.11%) ⬆️
unittests-android 45.56% <ø> (ø)
unittests-ios ?
unittests-rust 89.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jmartinesp jmartinesp merged commit be02439 into main Nov 20, 2023
10 checks passed
@jmartinesp jmartinesp deleted the fix/jme/android-add-inputtype-to-compose-editor branch November 20, 2023 09:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No capitalisation when typing a new message or after a period (.)
3 participants