Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Fix for dictation not working on iOS 17 #922

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jan 12, 2024

This should fix the issue for all iOS versions, since we are relying on a specific keyboard notification to intercept the state

fixes #921

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9a8cb9c) 87.39% compared to head (8e9a00f) 89.58%.

Files Patch % Lines
...mponents/WysiwygComposerView/WysiwygTextView.swift 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #922      +/-   ##
============================================
+ Coverage     87.39%   89.58%   +2.19%     
============================================
  Files           167      118      -49     
  Lines         19063    16917    -2146     
  Branches       1044      612     -432     
============================================
- Hits          16660    15155    -1505     
+ Misses         2096     1738     -358     
+ Partials        307       24     -283     
Flag Coverage Δ
uitests 79.04% <40.00%> (+8.37%) ⬆️
uitests-android ?
uitests-ios 79.04% <40.00%> (+0.14%) ⬆️
unittests 88.26% <40.00%> (+2.70%) ⬆️
unittests-android ?
unittests-ios 75.93% <40.00%> (+0.13%) ⬆️
unittests-rust 89.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 added the iOS label Jan 12, 2024
Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, ship it! 🚀

@Velin92 Velin92 merged commit ab19533 into main Jan 12, 2024
9 checks passed
@Velin92 Velin92 deleted the mauroromito/dictation_fix branch January 12, 2024 12:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Dictiation is broken on iOS 17.0 and above
3 participants