Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sending encrypted to_device #101

Merged
merged 20 commits into from
Aug 22, 2024

Conversation

BillCarsonFr
Copy link
Member

Depends on matrix-org/matrix-rust-sdk#3091

Add bindings to support sending custom encrypted to device event.
see matrix-org/matrix-js-sdk#3304

@BillCarsonFr BillCarsonFr force-pushed the valere/send_encrypted_to_device_support branch from e09ecc3 to 5e848ab Compare February 26, 2024 10:59
@BillCarsonFr BillCarsonFr marked this pull request as ready for review February 26, 2024 11:00
@BillCarsonFr BillCarsonFr requested a review from a team as a code owner February 26, 2024 11:00
CHANGELOG.md Outdated Show resolved Hide resolved
src/device.rs Outdated Show resolved Hide resolved
src/device.rs Outdated Show resolved Hide resolved
src/device.rs Outdated Show resolved Hide resolved
src/device.rs Outdated Show resolved Hide resolved
tests/device.test.js Outdated Show resolved Hide resolved
tests/device.test.js Outdated Show resolved Hide resolved
tests/device.test.js Outdated Show resolved Hide resolved
tests/device.test.js Outdated Show resolved Hide resolved
tests/device.test.js Outdated Show resolved Hide resolved
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the complicated serialization stuff :/

Hywan
Hywan previously requested changes Mar 11, 2024
src/device.rs Outdated Show resolved Hide resolved
src/device.rs Outdated Show resolved Hide resolved
src/device.rs Outdated Show resolved Hide resolved
src/device.rs Outdated Show resolved Hide resolved
richvdh and others added 8 commits August 22, 2024 20:35
…support' into valere/send_encrypted_to_device_support
There's not a lot of point jumping through hoops to turn the json-serialized
content back into an object in the Rust layer. Might as well leave it for
javascript.
@richvdh richvdh merged commit 9a167f7 into main Aug 22, 2024
3 checks passed
@richvdh richvdh deleted the valere/send_encrypted_to_device_support branch August 22, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants