Skip to content

Commit

Permalink
Use a type alias to allow bindings to take advantage of custom types
Browse files Browse the repository at this point in the history
  • Loading branch information
Daniel Salinas committed Dec 12, 2024
1 parent 54bd1d7 commit 4c7260c
Show file tree
Hide file tree
Showing 6 changed files with 32 additions and 18 deletions.
5 changes: 3 additions & 2 deletions bindings/matrix-sdk-ffi/src/event.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ use ruma::{
use crate::{
room_member::MembershipState,
ruma::{MessageType, NotifyType},
utils::Date64,
ClientError,
};

Expand All @@ -33,8 +34,8 @@ impl TimelineEvent {
self.0.sender().to_string()
}

pub fn timestamp(&self) -> u64 {
self.0.origin_server_ts().0.into()
pub fn timestamp(&self) -> Date64 {
self.0.origin_server_ts().into()
}

pub fn event_type(&self) -> Result<TimelineEventType, ClientError> {
Expand Down
6 changes: 3 additions & 3 deletions bindings/matrix-sdk-ffi/src/session_verification.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ use ruma::UserId;
use tracing::{error, info};

use super::RUNTIME;
use crate::error::ClientError;
use crate::{error::ClientError, utils::Date64};

#[derive(uniffi::Object)]
pub struct SessionVerificationEmoji {
Expand Down Expand Up @@ -46,7 +46,7 @@ pub struct SessionVerificationRequestDetails {
device_id: String,
display_name: Option<String>,
/// First time this device was seen in milliseconds since epoch.
first_seen_timestamp: u64,
first_seen_timestamp: Date64,
}

#[matrix_sdk_ffi_macros::export(callback_interface)]
Expand Down Expand Up @@ -242,7 +242,7 @@ impl SessionVerificationController {
flow_id: request.flow_id().into(),
device_id: other_device_data.device_id().into(),
display_name: other_device_data.display_name().map(str::to_string),
first_seen_timestamp: other_device_data.first_time_seen_ts().get().into(),
first_seen_timestamp: other_device_data.first_time_seen_ts().into(),
});
}
}
Expand Down
7 changes: 4 additions & 3 deletions bindings/matrix-sdk-ffi/src/timeline/content.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ use super::ProfileDetails;
use crate::{
error::ClientError,
ruma::{ImageInfo, MediaSource, MediaSourceExt, Mentions, MessageType, PollKind},
utils::Date64,
};

impl From<matrix_sdk_ui::timeline::TimelineItemContent> for TimelineItemContent {
Expand Down Expand Up @@ -187,7 +188,7 @@ pub enum TimelineItemContent {
max_selections: u64,
answers: Vec<PollAnswer>,
votes: HashMap<String, Vec<String>>,
end_time: Option<u64>,
end_time: Option<Date64>,
has_been_edited: bool,
},
CallInvite,
Expand Down Expand Up @@ -319,7 +320,7 @@ pub struct Reaction {
#[derive(Clone, uniffi::Record)]
pub struct ReactionSenderData {
pub sender_id: String,
pub timestamp: u64,
pub timestamp: Date64,
}

#[derive(Clone, uniffi::Enum)]
Expand Down Expand Up @@ -481,7 +482,7 @@ impl From<PollResult> for TimelineItemContent {
.map(|i| PollAnswer { id: i.id, text: i.text })
.collect(),
votes: value.votes,
end_time: value.end_time,
end_time: value.end_time.map(|t| t.into()),
has_been_edited: value.has_been_edited,
}
}
Expand Down
15 changes: 8 additions & 7 deletions bindings/matrix-sdk-ffi/src/timeline/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ use crate::{
VideoInfo,
},
task_handle::TaskHandle,
utils::Date64,
RUNTIME,
};

Expand Down Expand Up @@ -986,7 +987,7 @@ impl TimelineItem {
pub fn as_virtual(self: Arc<Self>) -> Option<VirtualTimelineItem> {
use matrix_sdk_ui::timeline::VirtualTimelineItem as VItem;
match self.0.as_virtual()? {
VItem::DateDivider(ts) => Some(VirtualTimelineItem::DateDivider { ts: ts.0.into() }),
VItem::DateDivider(ts) => Some(VirtualTimelineItem::DateDivider { ts: (*ts).into() }),
VItem::ReadMarker => Some(VirtualTimelineItem::ReadMarker),
}
}
Expand Down Expand Up @@ -1081,7 +1082,7 @@ pub struct EventTimelineItem {
is_own: bool,
is_editable: bool,
content: TimelineItemContent,
timestamp: u64,
timestamp: Date64,
reactions: Vec<Reaction>,
local_send_state: Option<EventSendState>,
read_receipts: HashMap<String, Receipt>,
Expand All @@ -1101,7 +1102,7 @@ impl From<matrix_sdk_ui::timeline::EventTimelineItem> for EventTimelineItem {
.into_iter()
.map(|(sender_id, info)| ReactionSenderData {
sender_id: sender_id.to_string(),
timestamp: info.timestamp.0.into(),
timestamp: info.timestamp.into(),
})
.collect(),
})
Expand All @@ -1118,7 +1119,7 @@ impl From<matrix_sdk_ui::timeline::EventTimelineItem> for EventTimelineItem {
is_own: item.is_own(),
is_editable: item.is_editable(),
content: item.content().clone().into(),
timestamp: item.timestamp().0.into(),
timestamp: item.timestamp().into(),
reactions,
local_send_state: item.send_state().map(|s| s.into()),
read_receipts,
Expand All @@ -1131,12 +1132,12 @@ impl From<matrix_sdk_ui::timeline::EventTimelineItem> for EventTimelineItem {

#[derive(Clone, uniffi::Record)]
pub struct Receipt {
pub timestamp: Option<u64>,
pub timestamp: Option<Date64>,
}

impl From<ruma::events::receipt::Receipt> for Receipt {
fn from(value: ruma::events::receipt::Receipt) -> Self {
Receipt { timestamp: value.ts.map(|ts| ts.0.into()) }
Receipt { timestamp: value.ts.map(|ts| ts.into()) }
}
}

Expand Down Expand Up @@ -1260,7 +1261,7 @@ pub enum VirtualTimelineItem {
DateDivider {
/// A timestamp in milliseconds since Unix Epoch on that day in local
/// time.
ts: u64,
ts: Date64,
},

/// The user's own read marker.
Expand Down
13 changes: 12 additions & 1 deletion bindings/matrix-sdk-ffi/src/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,20 @@
use std::{mem::ManuallyDrop, ops::Deref};

use async_compat::TOKIO1 as RUNTIME;
use ruma::UInt;
use ruma::{MilliSecondsSinceUnixEpoch, UInt};
use tracing::warn;

#[derive(Debug, Clone)]
pub struct Date64(u64);

impl From<MilliSecondsSinceUnixEpoch> for Date64 {
fn from(date: MilliSecondsSinceUnixEpoch) -> Self {
Self(date.0.into())
}
}

uniffi::custom_newtype!(Date64, u64);

pub(crate) fn u64_to_uint(u: u64) -> UInt {
UInt::new(u).unwrap_or_else(|| {
warn!("u64 -> UInt conversion overflowed, falling back to UInt::MAX");
Expand Down
4 changes: 2 additions & 2 deletions crates/matrix-sdk-ui/src/timeline/event_item/content/polls.rs
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ impl PollState {
.iter()
.map(|i| ((*i.0).to_owned(), i.1.iter().map(|i| i.to_string()).collect()))
.collect(),
end_time: self.end_event_timestamp.map(|millis| millis.0.into()),
end_time: self.end_event_timestamp,
has_been_edited: self.has_been_edited,
}
}
Expand Down Expand Up @@ -178,7 +178,7 @@ pub struct PollResult {
pub max_selections: u64,
pub answers: Vec<PollResultAnswer>,
pub votes: HashMap<String, Vec<String>>,
pub end_time: Option<u64>,
pub end_time: Option<MilliSecondsSinceUnixEpoch>,
pub has_been_edited: bool,
}

Expand Down

0 comments on commit 4c7260c

Please sign in to comment.