feat(media): don't clone the data when uploading an encrypted media

matrix-org · Oct 22, 2024 · 53b40c9 · 53b40c9
1 parent 92de0e2
commit 53b40c9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/crates/matrix-sdk/src/encryption/mod.rs b/crates/matrix-sdk/src/encryption/mod.rs
@@ -456,7 +456,7 @@ impl Client {
     pub(crate) async fn upload_encrypted_media_and_thumbnail(
         &self,
         content_type: &mime::Mime,
-        data: Vec<u8>,
+        data: &[u8],
         thumbnail: Option<Thumbnail>,
         send_progress: SharedObservable<TransmissionProgress>,
     ) -> Result<(MediaSource, Option<MediaSource>, Option<Box<ThumbnailInfo>>)> {

diff --git a/crates/matrix-sdk/src/room/mod.rs b/crates/matrix-sdk/src/room/mod.rs
@@ -1936,12 +1936,7 @@ impl Room {
         #[cfg(feature = "e2e-encryption")]
         let (media_source, thumbnail_source, thumbnail_info) = if self.is_encrypted().await? {
             self.client
-                .upload_encrypted_media_and_thumbnail(
-                    content_type,
-                    data.clone(),
-                    thumbnail,
-                    send_progress,
-                )
+                .upload_encrypted_media_and_thumbnail(content_type, &data, thumbnail, send_progress)
                 .await?
         } else {
             self.client