Skip to content

Commit

Permalink
fix(ui): Disable share_pos() inside RoomListService.
Browse files Browse the repository at this point in the history
This patch disables the call to `share_pos()` inside the
`RoomListService` because it creates slowness we need to investigate.
  • Loading branch information
Hywan committed Nov 13, 2024
1 parent 9dd2d5e commit a920c3f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
7 changes: 4 additions & 3 deletions crates/matrix-sdk-ui/src/room_list_service/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,10 @@ impl RoomListService {
}))
.with_typing_extension(assign!(http::request::Typing::default(), {
enabled: Some(true),
}))
// We don't deal with encryption device messages here so this is safe
.share_pos();
}));
// TODO: Re-enable once we know it creates slowness.
// // We don't deal with encryption device messages here so this is safe
// .share_pos();

let sliding_sync = builder
.add_cached_list(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,7 @@ async fn test_sync_resumes_from_previous_state() -> Result<(), Error> {
}

#[async_test]
#[ignore] // `share_pos()` has been disabled in the room list, see there to learn more.
async fn test_sync_resumes_from_previous_state_after_restart() -> Result<(), Error> {
let tmp_dir = TempDir::new().unwrap();
let store_path = tmp_dir.path();
Expand Down

0 comments on commit a920c3f

Please sign in to comment.