-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ffi: Expose encryption settings via FFI #3326
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3326 +/- ##
==========================================
+ Coverage 83.65% 83.67% +0.01%
==========================================
Files 238 238
Lines 24668 24668
==========================================
+ Hits 20637 20640 +3
+ Misses 4031 4028 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see the PR is marked as draft, so I'll do another round of review when ready.
875a1cf
to
516e9a1
Compare
c5f9207
to
0f86532
Compare
71c6878
to
7c2d77c
Compare
7c2d77c
to
e22a7c7
Compare
e22a7c7
to
ebcf1c4
Compare
Review was one week ago, and there's been many pushes since then
Fixes #3130
This allows providing encryption settings while constructing a client via FFI, instead of hard-coding specific values.
We do it by holding on to an
EncryptionSettings
insideClientBuilder
and updating it when certain methods on the builder are called. Duringbuild_inner()
we provide thoseEncryptionSettings
by callingwith_encryption_settings
oninner_builder
.I added an enum
BackupDownloadStrategy
to be passed as an argument tobackup_download_strategy
. Let me know if there's a better way.