integration test: sync longer in test_room_preview before considering it stable
#3504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that the failure came when using the known room path in the room preview: Alice knows about the room, but for some reason the client didn't retrieve all the state events from the sliding sync proxy yet. Before, the sync would be considered stable after 2 seconds. This is too little, considering that events come from the proxy that listens to events from synapse. Raising this threshold to 15 seconds should help getting all the room information from the proxy, and thus get all the information we expected in the client.
bnjbvr
changed the title
test_room_preview before considering it stable
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3504 +/- ##
=======================================
Coverage 83.72% 83.73%
=======================================
Files 255 255
Lines 25778 25778
=======================================
+ Hits 21583 21584 +1
+ Misses 4195 4194 -1 ☔ View full report in Codecov by Sentry. |
Wrong issue number? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the failure came when using the known room path in the room preview: Alice knows about the room, but for some reason the client didn't retrieve all the state events from the sliding sync proxy yet.
Before, the sync would be considered stable after 2 seconds. This is too little, considering that events come from the proxy that listens to events from synapse. Raising this threshold to 15 seconds should help getting all the room information from the proxy, and thus get all the information we expected in the client.
Fixes #3483.