Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

widget API(ffi): Add StateEventType::RoomEncryption to capabilities #3506

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Jun 4, 2024

also add TODO comment to remove. org.matrix.msc3401.call once possible.

Add TODO comment to remove `org.matrix.msc3401.call` once possible.
@toger5 toger5 requested a review from a team as a code owner June 4, 2024 12:35
@toger5 toger5 requested review from bnjbvr and removed request for a team June 4, 2024 12:35
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.73%. Comparing base (bffcb26) to head (32fea6b).
Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3506   +/-   ##
=======================================
  Coverage   83.72%   83.73%           
=======================================
  Files         255      255           
  Lines       25778    25778           
=======================================
+ Hits        21583    21585    +2     
+ Misses       4195     4193    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnjbvr bnjbvr changed the title Add StateEventType::RoomEncryption to capabilities. widget API(ffi): Add StateEventType::RoomEncryption to capabilities. Jun 4, 2024
@bnjbvr bnjbvr changed the title widget API(ffi): Add StateEventType::RoomEncryption to capabilities. widget API(ffi): Add StateEventType::RoomEncryption to capabilities Jun 4, 2024
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also run cargo xtask fixup style?

bindings/matrix-sdk-ffi/src/widget.rs Outdated Show resolved Hide resolved
@toger5 toger5 requested a review from bnjbvr June 6, 2024 17:21
@bnjbvr bnjbvr merged commit 931c564 into main Jun 6, 2024
38 checks passed
@bnjbvr bnjbvr deleted the toger5/widget-capability-element-call-fix branch June 6, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants