Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: rename "sending queue" to "send queue" #3518

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Jun 6, 2024

Let's use uniform naming. Just a renaming PR. Easy to review. Thank you in advance for smashing that "approve" button.

@bnjbvr bnjbvr requested a review from a team as a code owner June 6, 2024 15:12
@bnjbvr bnjbvr requested review from Hywan and removed request for a team June 6, 2024 15:12
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smashed.

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.79%. Comparing base (5093af8) to head (035dc92).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/matrix-sdk/src/send_queue.rs 93.75% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3518   +/-   ##
=======================================
  Coverage   83.79%   83.79%           
=======================================
  Files         254      254           
  Lines       25723    25723           
=======================================
  Hits        21554    21554           
  Misses       4169     4169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnjbvr bnjbvr enabled auto-merge (rebase) June 6, 2024 15:55
@bnjbvr bnjbvr merged commit 66330a2 into main Jun 6, 2024
38 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/send-sending-queue-potato-potato branch June 6, 2024 15:56
@bnjbvr
Copy link
Member Author

bnjbvr commented Jun 6, 2024

Duh, I missed sending_queue() 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants