UTD hook: stop re-reporting of UTDs on app relaunch #3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll need this for persisting the data to storage.
We're going to add some more stuff here, and it's going to be async, so a separate function will be helpful.
This isn't all that much use at the moment: we need to add persistence to the store. To limit the growth rate of reported_utds, use a bloom filter instead of a set.
This is now redundant.
richvdh
force-pushed
the
rav/deduplicate_utds2
branch
from
515a8c8 to
21bc95e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3519 +/- ##
==========================================
+ Coverage 83.79% 83.81% +0.01%
==========================================
Files 254 254
Lines 25723 25765 +42
==========================================
+ Hits 21555 21595 +40
- Misses 4168 4170 +2 ☔ View full report in Codecov by Sentry. |
richvdh
force-pushed
the
rav/deduplicate_utds2
branch
from
21bc95e to
1b7f05f
Compare
richvdh
commented
Jun 7, 2024
| @@ -9,7 +9,14 @@ Breaking changes: | |||
| Bug fixes: | |||
|
|
|||
| - `UtdHookManager` no longer re-reports UTD events as late decryptions. | |||
| ([#3840](https://github.com/matrix-org/matrix-rust-sdk/pull/3840)) | |||
| ([#3480](https://github.com/matrix-org/matrix-rust-sdk/pull/3480)) | |||
There was a problem hiding this comment.
fixing a typo while I'm here 😇
|
FYI I tested this PR with Element X. No source breaking changes. As required I tested logout, and it's not crashing. Also after puting the app in background, killing and re-open it it's not reporting again 
|
bnjbvr
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to #3374, and a re-do of #3490.
The principle remains to use a Bloom filter to keep track of which events we have already reported to the parent UTD hook. We load the data from database on startup; we now flush it out immediately on every update.