-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bindings): use the same library name for all platforms in the xcframework #3536
fix(bindings): use the same library name for all platforms in the xcframework #3536
Conversation
…ramework Fixes: matrix-org#3528 Signed-off-by: Johannes Marbach <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3536 +/- ##
=======================================
Coverage 83.86% 83.86%
=======================================
Files 254 254
Lines 25831 25831
=======================================
Hits 21664 21664
Misses 4167 4167 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, but hard to double check without a Apple machine.
@stefanceriu can you double check if this is fine for you guys?
Yup yup, leave it with me, it might just take me a bit to get to it 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alrighty, I had a go at building the whole thing and it not only looks great but it also works 😁
🚀 it and thank you for handling it yourself!
Thanks for reviewing it so quickly! 🙂 |
@Johennes made a new release here https://github.com/matrix-org/matrix-rust-components-swift/releases/tag/v1.1.68 if you want to try it out. Seems fine on our side fwiw. |
Tested and works in RN as well. 🎉 Thanks again! |
Fixes: #3528