Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bindings): use the same library name for all platforms in the xcframework #3536

Merged

Conversation

Johennes
Copy link
Contributor

Fixes: #3528

  • Public API changes documented in changelogs (optional)

@Johennes Johennes requested a review from a team as a code owner June 11, 2024 18:46
@Johennes Johennes requested review from poljar and removed request for a team June 11, 2024 18:46
@Johennes Johennes marked this pull request as draft June 11, 2024 18:46
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.86%. Comparing base (d035eb1) to head (67f488b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3536   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files         254      254           
  Lines       25831    25831           
=======================================
  Hits        21664    21664           
  Misses       4167     4167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Johennes Johennes marked this pull request as ready for review June 11, 2024 19:01
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but hard to double check without a Apple machine.

@stefanceriu can you double check if this is fine for you guys?

@stefanceriu
Copy link
Member

Yup yup, leave it with me, it might just take me a bit to get to it 👍

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrighty, I had a go at building the whole thing and it not only looks great but it also works 😁

🚀 it and thank you for handling it yourself!

@bnjbvr bnjbvr merged commit f770248 into matrix-org:main Jun 12, 2024
74 checks passed
@Johennes
Copy link
Contributor Author

Thanks for reviewing it so quickly! 🙂

@stefanceriu
Copy link
Member

@Johennes made a new release here https://github.com/matrix-org/matrix-rust-components-swift/releases/tag/v1.1.68 if you want to try it out. Seems fine on our side fwiw.

@Johennes
Copy link
Contributor Author

Tested and works in RN as well. 🎉

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the same library name in the XCFramework / Swift bindings for all platforms
4 participants