feat(sdk): Implement event_cache::Deduplicator
#3580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have notice we have a growable bloom filter in our direct deps already, we should use it instead of introducing a new one: Line 39 in 9aa2774 |
Hywan
force-pushed
the
feat-sdk-event-cache-dedup-events
branch
2 times, most recently
from
bb7fcd1 to
713cc08
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3580 +/- ##
==========================================
- Coverage 84.70% 84.56% -0.14%
==========================================
Files 269 270 +1
Lines 28766 28862 +96
==========================================
+ Hits 24366 24407 +41
- Misses 4400 4455 +55 ☔ View full report in Codecov by Sentry. |
Hywan
force-pushed
the
feat-sdk-event-cache-dedup-events
branch
from
134d7f6 to
b5224aa
Compare
Hywan
force-pushed
the
feat-sdk-event-cache-dedup-events
branch
2 times, most recently
from
6fecc07 to
5b1949c
Compare
This patch adds an `Event` type alias to `SyncTimelineEvent` to (i) make the code shorter, (ii) remove some cognitive effort, (iii) make things more convenient.
This patch adds unit tests for the `RoomEvents`' methods.
This patch adds the `LinkedChunk::remove_item_at` method, along with `Update::RemoveItem` variant.
This is only code move, nothing has changed.
This is a clean up patch, nothing fancy.
This is another clean up patch.
This patch fixes a bug in an optimisation inside `UpdateToVectorDiff` when an `Update::PushItems` is handled. It can sometimes create `VectorDiff::Append` instead of a `VectorDiff::Insert`. The tests will be part of the next patch.
…ateToVectorDiff`. This patch implements the support of `Update::RemoveItem` inside `UpdateToVectorDiff` to emit a `VectorDiff::Remove`.
Hywan
force-pushed
the
feat-sdk-event-cache-dedup-events
branch
from
e75192f to
b578f38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP of an event deduplicator implemented on top of a Bloom filter. It works great, but it doesn't solve all issues we have right now. Right now, it filters duplicated events; instead, it should collect duplicated events with their positions, so that they can be removed from the
LinkedChunkbefore being re-inserted. It's the basis to implement a naive reconciliation in theEventCache.EventCachestorage #3280