-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Element specific well-known support #3617
Conversation
I'm a bit curious, what kind of requests are you doing outside the SDK? 👀 |
Have a look at the linked issue and ElementX PR |
… SDK's inner HTTP client.
…ent user's identifier.
bbfa9de
to
1b3be24
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3617 +/- ##
==========================================
+ Coverage 84.17% 84.19% +0.02%
==========================================
Files 255 255
Lines 26515 26517 +2
==========================================
+ Hits 22319 22327 +8
+ Misses 4196 4190 -6 ☔ View full report in Codecov by Sentry. |
…alize it from external clients
1b3be24
to
d505ad1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this is simple enough and fine for now, though we really need to start thinking about a Element specific crate more seriously.
Left a small nit.
Handles part of element-hq/element-meta/issues/2441
Powers element-hq/element-x-ios#2971