ci: Add a github workflow to fail when fixup commits exist #3624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3624 +/- ##
==========================================
+ Coverage 84.17% 84.18% +0.01%
==========================================
Files 255 255
Lines 26515 26515
==========================================
+ Hits 22319 22322 +3
+ Misses 4196 4193 -3 ☔ View full report in Codecov by Sentry. |
We tend to use fixup commits quite a bit, and in the heat of the moment we sometimes forget to squash them before the final merge. This should prevent us from doing so.
poljar
force-pushed
the
poljar/fixup-commit-ci-workflow
branch
from
14cc0ed to
42a4abf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tend to use fixup commits quite a bit, and in the heat of the moment we sometimes forget to squash them before the final merge.
This should prevent us from doing so.