ffi: Timeline::load_reply_details checks if the event exists locally #3656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinesp
force-pushed
the
jme/ffi-load-reply-details-should-check-the-timeline-first
branch
from
997d028 to
757190c
Compare
jmartinesp
force-pushed
the
jme/ffi-load-reply-details-should-check-the-timeline-first
branch
2 times, most recently
from
af423c9 to
fc1ad35
Compare
bnjbvr
approved these changes
Jul 4, 2024
Comment on lines
646
to
647
| let ret = self.inner.room().event(&event_id).await; | ||
| match ret { |
There was a problem hiding this comment.
nit: can we get rid of the ret temporary variable please?
Before it would go fetch the event from the server using a network request.
jmartinesp
force-pushed
the
jme/ffi-load-reply-details-should-check-the-timeline-first
branch
from
fc1ad35 to
5217a74
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3656 +/- ##
==========================================
- Coverage 84.25% 84.22% -0.04%
==========================================
Files 259 259
Lines 26595 26595
==========================================
- Hits 22408 22400 -8
- Misses 4187 4195 +8 ☔ View full report in Codecov by Sentry. |
bnjbvr
deleted the
jme/ffi-load-reply-details-should-check-the-timeline-first
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it would go fetch the event from the server using a network request.
Fixes #3589
Signed-off-by: