crypto: Re-use existing get_device_from_curve_key method #3756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These calls are equivalent because the old code called `self.get_user_devices` with a `timeout` of `None`, which meant the call to `wait_if_user_pending` inside was a no-op.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3756 +/- ##
==========================================
- Coverage 84.03% 84.02% -0.01%
==========================================
Files 260 260
Lines 26732 26729 -3
==========================================
- Hits 22463 22459 -4
- Misses 4269 4270 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These calls are equivalent because the old code called
self.get_user_deviceswith atimeoutofNone, which meant the call towait_if_user_pendinginside was a no-op.