Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: Simplify the interface of search_for_device #3757

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

andybalaam
Copy link
Contributor

Identical to #3748 except this time against the right branch 🤦

@andybalaam andybalaam requested a review from a team as a code owner July 23, 2024 13:48
@andybalaam andybalaam requested review from poljar and jmartinesp and removed request for a team and poljar July 23, 2024 13:48
@andybalaam andybalaam enabled auto-merge (rebase) July 23, 2024 13:50
Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... again? 😅

I just had the weirdest déjà vu.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.03%. Comparing base (dfdea0c) to head (a61b716).
Report is 1 commits behind head on main.

Files Patch % Lines
...rypto/src/olm/group_sessions/sender_data_finder.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3757   +/-   ##
=======================================
  Coverage   84.03%   84.03%           
=======================================
  Files         260      260           
  Lines       26732    26732           
=======================================
  Hits        22463    22463           
  Misses       4269     4269           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andybalaam andybalaam merged commit 99da0ff into main Jul 23, 2024
40 checks passed
@andybalaam andybalaam deleted the andybalaam/search-for-device-uses-userid2 branch July 23, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants