dependent events: followup #3760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3760 +/- ##
==========================================
- Coverage 84.08% 84.02% -0.06%
==========================================
Files 260 260
Lines 27031 27036 +5
==========================================
- Hits 22730 22718 -12
- Misses 4301 4318 +17 ☔ View full report in Codecov by Sentry. |
andybalaam
approved these changes
Jul 25, 2024
|
@andybalaam For what it's worth, I've added a small commit that's a big "duh" from me: the previous PR introduced a transaction id for the dependent event, but forgot to make use of it. This isn't a big deal for edits/redacts, but it would have been a massive failure for reactions. I've addressed it here for edits/redacts, which isn't a big change, but wanted to let you know before I autosquash and merge later. |
|
All looks good to me, thanks! |
bnjbvr
force-pushed
the
bnjbvr/dependent-events-followups
branch
from
7ed0fd2 to
b023b7d
Compare
…istinguish the parent from the child transaction id
…network queries Intense facepalm energy here.
bnjbvr
force-pushed
the
bnjbvr/dependent-events-followups
branch
from
b023b7d to
a466751
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm tired. Here are some improvements/bugfixes for the dependent event mechanism.